Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade golangci-lint version to v1.60.3 and fix lint #3414

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

demoManito
Copy link
Member

@demoManito demoManito commented Aug 30, 2024

Description (what this PR does / why we need it):

  1. lower golangci-lint versions cannot detect errors in the order of import packages
  2. new version of golangci-lint gomnd is replaced by mnd
  3. fix some remaining lint issues

Which issue(s) this PR fixes (resolves / be part of):

Other special notes for the reviewers:

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. size:M This PR changes 30-99 lines, ignoring generated files. size:L This PR changes 100-499 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. size:M This PR changes 30-99 lines, ignoring generated files. labels Aug 30, 2024
@demoManito demoManito changed the title chore: upgrade golangci-lint version to v1.60.3 chore: upgrade golangci-lint version to v1.60.3 and fix lint Sep 2, 2024
@demoManito
Copy link
Member Author

@shenqidebaozi PTAL

@dosubot dosubot bot added the LGTM label Sep 2, 2024
@daemon365 daemon365 merged commit 186ab88 into main Oct 8, 2024
63 checks passed
@daemon365 daemon365 deleted the bump/golangci-lint/version branch October 8, 2024 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LGTM size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants